-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Haprog/update supported browsers #548
Conversation
Explicitly document browser support in the readme and align it with the browser support of Vaadin platform. BREAKING CHANGE: Notably this drops official support for IE 11 and old versions of Safari. See the readme for currently supported browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the browser list config probably also needs updating: https://github.com/vaadin/vaadin-router/blob/9d9898056e2b8cf032df44705ce71edbb0aeb5bb/package.json#L57-L67
browserName: 'chrome', | ||
browserVersion: 'latest' | ||
}, | ||
{ | ||
deviceName: 'Android GoogleAPI Emulator', | ||
platformName: 'Android', | ||
platformVersion: '9.0', | ||
platformVersion: '10.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sauce Labs has sent an email claiming that ACTION REQUIRED for the vaadin-router testing config. This may be relevant here:
Hello,
Sauce Labs is scheduling to update Android 10 to a newer browser version of Chrome on Monday, February 22nd, 2021. The update will take Chrome from version 74 to version 86. Testing on this version of Chrome and all subsequent versions will primarily support the W3C WebDriver protocol.
In order to continue testing with Android 10, users are REQUIRED to make changes to their WebDriver capabilities. To prepare for this update, we recommend that you create a new version of your test scripts that include the W3C capabilities and on February 22nd, replace your existing script with this updated version.
To ensure that you do not have any downtime, please update your current tests. If you are unable to update your tests to be W3C compliant yet, please review our example below for setting W3C capabilities to false. For help, view the W3C documentation.
Code Example:
Before (JSONWP):
{ "browserName": "chrome", "deviceName": "Android GoogleAPI Emulator", "platformName": "Android", "platformVersion": "10.0", "automationName": "UiAutomator2", "appiumVersion": "1.18.1", "name": "Appium JSONWP Test" },After (W3C):
{ "browserName": "chrome", "appium:deviceName": "Android GoogleAPI Emulator", "platformName": "Android", "appium:platformVersion": "10.0", "automationName": "UiAutomator2", "sauce:options": { "appiumVersion": "1.18.1", "name": "Appium W3C Test" } }Or, IF you are unable to enable W3C by then and still want to use the old JSONWP in combination with the latest version of ChromeDriver you can add the following to your capabilities below. Please note that when Selenium 4 is released the chance will be very high that browser-vendors will remove the old JSONWP from their drivers which eventually will break your tests.
{ "browserName": "chrome", "deviceName": "Android GoogleAPI Emulator", "platformName": "Android", "platformVersion": "10.0", "automationName": "UiAutomator2", "appiumVersion": "1.18.1", "name": "Appium JSONWP W3C False Test" "goog:chromeOptions": { "w3c": false } },In addition, we plan to update the default version of Appium for Android 10 from 1.8.0 to 1.18.0. This will unlock features and capabilities available on the newer version. If Appium 1.8.0 is still required for testing, it can be specified within the capabilities. We will release a blog update when the update is live to minimize the impact this may have on your work.
If you have questions or need assistance, please contact our Support team at support@saucelabs.com.
Happy Testing!
Sauce Labs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The way I read it is we can't move to the new W3C Test yet but should do it on/after Feb 22nd. I think we can keep this part as is for now and update it later when/if it breaks. But good that you noticed this, now we're aware that this change is coming and not surprised if this test breaks later this month. :)
Update browserslist definitions in package.json to match supported browsers documented in readme.
Thanks. I hadn't noticed this part in package.json. Now it's updated to match the supported browsers as best I could. I think it's accurate now (compare to Desktop Browsers section at https://github.com/vaadin/platform/releases/tag/18.0.1) |
For some reason the latest Travis build failed on lint:css task but I can't get it to fail locally. Trying to rerun Travis job now. |
No description provided.