Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Haprog/update supported browsers #548

Merged
merged 5 commits into from
Feb 3, 2021
Merged

Haprog/update supported browsers #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acf5f28
chore: update CI browser capabilities
Haprog Jan 29, 2021
14c9379
docs!: update browser support
Haprog Jan 29, 2021
fd6d611
chore: update browserslist
Haprog Feb 1, 2021
6b9ef2d
chore: update yarn.lock
Haprog Feb 1, 2021
12f60d6
Merge branch 'master' into haprog/update-supported-browsers
Haprog Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,25 @@ router.setRoutes([
```

## Browser support

A specific version of Vaadin Router supports the same browsers as the Vaadin platform major version which includes that version of Vaadin Router.
See [Vaadin platform release notes](https://github.com/vaadin/platform/releases) for details on included Vaadin Router version and supported technologies.
The Supported Technologies section is typically listed in the release notes of the first publicly available release of a Vaadin platform major version
(for example [Vaadin 18.0.1](https://github.com/vaadin/platform/releases/tag/18.0.1) since 18.0.0 was skipped).

### Desktop browsers

Evergreen versions of the following browsers
- Chrome, Firefox, Firefox ESR, Safari and Edge (Chromium)

### Mobile browsers

Built-in browsers in the following mobile operating systems:
- Safari starting from iOS 13 (Safari 13 or newer)
- Google Chrome evergreen on Android (requiring Android 4.4 or newer)

### Sauce Labs test status

[![Sauce Test Status](https://saucelabs.com/browser-matrix/vaadin-router.svg)](https://saucelabs.com/u/vaadin-router)

### Big Thanks
Expand Down
18 changes: 8 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,13 @@
}
],
"browserslist": [
"last 2 Chrome major versions",
"last 2 Android major versions",
"last 2 Firefox major versions",
"last 2 Edge major versions",
"last 2 Safari major versions",
"last 2 iOS major versions",
"Safari 9",
"iOS 9",
"IE 11"
"last 1 Chrome major versions",
"last 1 Firefox major versions",
"Firefox ESR",
"last 1 Edge major versions",
"Safari >= 13",
"iOS >= 13",
"last 1 ChromeAndroid major versions"
],
"dependencies": {
"@vaadin/vaadin-usage-statistics": "^2.1.0",
Expand All @@ -78,7 +76,7 @@
"@types/form-data": "^2.5.0",
"bower": "^1.8.8",
"browser-sync": "^2.26.14",
"browserslist": "^4.14.5",
"browserslist": "^4.16.3",
"bundlesize": "^0.18.0",
"eslint": "^7.19.0",
"eslint-config-vaadin": "0.2.7",
Expand Down
17 changes: 8 additions & 9 deletions wct.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ module.exports = {
{
deviceName: 'Android GoogleAPI Emulator',
platformName: 'Android',
platformVersion: '10.0',
platformVersion: '11.0',
browserName: 'chrome',
browserVersion: 'latest'
},
{
deviceName: 'Android GoogleAPI Emulator',
platformName: 'Android',
platformVersion: '9.0',
platformVersion: '10.0',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sauce Labs has sent an email claiming that ACTION REQUIRED for the vaadin-router testing config. This may be relevant here:

Hello,

Sauce Labs is scheduling to update Android 10 to a newer browser version of Chrome on Monday, February 22nd, 2021. The update will take Chrome from version 74 to version 86. Testing on this version of Chrome and all subsequent versions will primarily support the W3C WebDriver protocol.

In order to continue testing with Android 10, users are REQUIRED to make changes to their WebDriver capabilities. To prepare for this update, we recommend that you create a new version of your test scripts that include the W3C capabilities and on February 22nd, replace your existing script with this updated version.

To ensure that you do not have any downtime, please update your current tests. If you are unable to update your tests to be W3C compliant yet, please review our example below for setting W3C capabilities to false. For help, view the W3C documentation.

Code Example:

Before (JSONWP):

{
      "browserName": "chrome",
      "deviceName": "Android GoogleAPI Emulator",
      "platformName": "Android",
      "platformVersion": "10.0",
      "automationName": "UiAutomator2",
      "appiumVersion": "1.18.1",
      "name": "Appium JSONWP Test"
},

After (W3C):

{
      "browserName": "chrome",
      "appium:deviceName": "Android GoogleAPI Emulator",
      "platformName": "Android",
      "appium:platformVersion": "10.0",
      "automationName": "UiAutomator2",
      "sauce:options": {
            "appiumVersion": "1.18.1",
            "name": "Appium W3C Test"
      }
}

Or, IF you are unable to enable W3C by then and still want to use the old JSONWP in combination with the latest version of ChromeDriver you can add the following to your capabilities below. Please note that when Selenium 4 is released the chance will be very high that browser-vendors will remove the old JSONWP from their drivers which eventually will break your tests.

{
      "browserName": "chrome",
      "deviceName": "Android GoogleAPI Emulator",
      "platformName": "Android",
      "platformVersion": "10.0",
      "automationName": "UiAutomator2",
      "appiumVersion": "1.18.1",
      "name": "Appium JSONWP W3C False Test"
      "goog:chromeOptions": {
            "w3c": false
      }
},

In addition, we plan to update the default version of Appium for Android 10 from 1.8.0 to 1.18.0. This will unlock features and capabilities available on the newer version. If Appium 1.8.0 is still required for testing, it can be specified within the capabilities. We will release a blog update when the update is live to minimize the impact this may have on your work.

If you have questions or need assistance, please contact our Support team at support@saucelabs.com.

Happy Testing!

Sauce Labs

Copy link
Contributor Author

@Haprog Haprog Feb 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The way I read it is we can't move to the new W3C Test yet but should do it on/after Feb 22nd. I think we can keep this part as is for now and update it later when/if it breaks. But good that you noticed this, now we're aware that this change is coming and not surprised if this test breaks later this month. :)

browserName: 'chrome',
browserVersion: 'latest-1'
},
Expand All @@ -29,23 +29,22 @@ module.exports = {
'Windows 10/firefox@latest',
'Windows 10/firefox@latest-1',

// last Firefox ESR version (desktop)
// SauceLabs doesn't have ESR versions so testing
// the regular release of the same major version here
'Windows 10/firefox@78.0',

// last 2 Edge major versions (desktop)
'Windows 10/microsoftedge@latest',
'Windows 10/microsoftedge@latest-1',

// last 2 Safari major versions (desktop)
'macOS 11.00/safari@latest',
'macOS 10.15/safari@latest',
'macOS 10.14/safari@latest',

// last 2 iOS major versions (mobile Safari)
'iOS Simulator/iphone@latest',
'iOS Simulator/iphone@latest-1',

// Safari 9 on desktop and mobile
'OS X 10.11/safari@9.0',

// IE11
'Windows 7/internet explorer@11',
];
}

Expand Down
26 changes: 26 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3004,6 +3004,17 @@ browserslist@^4.15.0:
escalade "^3.1.1"
node-releases "^1.1.67"

browserslist@^4.16.3:
version "4.16.3"
resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-4.16.3.tgz#340aa46940d7db878748567c5dea24a48ddf3717"
integrity sha512-vIyhWmIkULaq04Gt93txdh+j02yX/JzlyhLYbV3YQCn/zvES3JnY7TifHHvvr1w5hTDluNKMkV05cs4vy8Q7sw==
dependencies:
caniuse-lite "^1.0.30001181"
colorette "^1.2.1"
electron-to-chromium "^1.3.649"
escalade "^3.1.1"
node-releases "^1.1.70"

browserstack@^1.2.0:
version "1.5.3"
resolved "https://registry.yarnpkg.com/browserstack/-/browserstack-1.5.3.tgz#93ab48799a12ef99dbd074dd595410ddb196a7ac"
Expand Down Expand Up @@ -3212,6 +3223,11 @@ caniuse-lite@^1.0.30001165:
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001166.tgz#ca73e8747acfd16a4fd6c4b784f1b995f9698cf8"
integrity sha512-nCL4LzYK7F4mL0TjEMeYavafOGnBa98vTudH5c8lW9izUjnB99InG6pmC1ElAI1p0GlyZajv4ltUdFXvOHIl1A==

caniuse-lite@^1.0.30001181:
version "1.0.30001181"
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001181.tgz#4f0e5184e1ea7c3bf2727e735cbe7ca9a451d673"
integrity sha512-m5ul/ARCX50JB8BSNM+oiPmQrR5UmngaQ3QThTTp5HcIIQGP/nPBs82BYLE+tigzm3VW+F4BJIhUyaVtEweelQ==

capture-stack-trace@^1.0.0:
version "1.0.1"
resolved "https://registry.yarnpkg.com/capture-stack-trace/-/capture-stack-trace-1.0.1.tgz#a6c0bbe1f38f3aa0b92238ecb6ff42c344d4135d"
Expand Down Expand Up @@ -4408,6 +4424,11 @@ electron-to-chromium@^1.3.621:
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.627.tgz#4acdbbbbe31eb605fba8380063fd9c8a7e5ca4a0"
integrity sha512-O5IVRS4sCxP2+vECAp7uHkaI8V+dKYpuCyBcLn+hqVAOy/RONd8zx+6eH7TuWSTBYs/oUrzBXkNMZuVsQd58kQ==

electron-to-chromium@^1.3.649:
version "1.3.649"
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.649.tgz#3aa8be052d4d268ede45d8e98d0cd60ffefad607"
integrity sha512-ojGDupQ3UMkvPWcTICe4JYe17+o9OLiFMPoduoR72Zp2ILt1mRVeqnxBEd6s/ptekrnsFU+0A4lStfBe/wyG/A==

emitter-component@^1.1.1:
version "1.1.1"
resolved "https://registry.yarnpkg.com/emitter-component/-/emitter-component-1.1.1.tgz#065e2dbed6959bf470679edabeaf7981d1003ab6"
Expand Down Expand Up @@ -8082,6 +8103,11 @@ node-releases@^1.1.67:
resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-1.1.67.tgz#28ebfcccd0baa6aad8e8d4d8fe4cbc49ae239c12"
integrity sha512-V5QF9noGFl3EymEwUYzO+3NTDpGfQB4ve6Qfnzf3UNydMhjQRVPR1DZTuvWiLzaFJYw2fmDwAfnRNEVb64hSIg==

node-releases@^1.1.70:
version "1.1.70"
resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-1.1.70.tgz#66e0ed0273aa65666d7fe78febe7634875426a08"
integrity sha512-Slf2s69+2/uAD79pVVQo8uSiC34+g8GWY8UH2Qtqv34ZfhYrxpYpfzs9Js9d6O0mbDmALuxaTlplnBTnSELcrw==

node-status-codes@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/node-status-codes/-/node-status-codes-1.0.0.tgz#5ae5541d024645d32a58fcddc9ceecea7ae3ac2f"
Expand Down