Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Bump Web Component version to 5.7.4 #1121

Merged
merged 4 commits into from
Sep 25, 2020

Conversation

tomivirkki
Copy link
Member

No description provided.

@tomivirkki tomivirkki marked this pull request as draft September 21, 2020 13:49
@tomivirkki tomivirkki changed the title Bump Web Component version to 5.7.2 Bump Web Component version to 5.7.3 Sep 22, 2020
@tomivirkki tomivirkki force-pushed the bump-dependency-version-1600695981912 branch from 709a267 to 9512579 Compare September 25, 2020 07:11
@tomivirkki tomivirkki changed the title Bump Web Component version to 5.7.3 Bump Web Component version to 5.7.4 Sep 25, 2020
@tomivirkki tomivirkki marked this pull request as ready for review September 25, 2020 07:11
@vaadin-bot
Copy link

SonarQube analysis reported 32 issues

  • CRITICAL 2 critical
  • MAJOR 8 major
  • MINOR 19 minor
  • INFO 3 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L2358: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L3110: Define a constant instead of duplicating this literal "direction" 4 times. rule
  3. MAJOR Grid.java#: This file has 1,767 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR Grid.java#L1894: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR Grid.java#L1895: Either log or rethrow this exception. rule
  6. MAJOR Grid.java#L1914: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L2923: Call "Optional#isPresent()" before accessing the value. rule
  8. MAJOR Grid.java#L2933: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L3632: Rename "editor" which hides the field declared at line 1164. rule
  10. MAJOR Grid.java#L4043: Remove this unused method parameter "event". rule

@tomivirkki tomivirkki merged commit ab7c1ff into master Sep 25, 2020
@tomivirkki tomivirkki deleted the bump-dependency-version-1600695981912 branch September 25, 2020 07:54
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants