Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Bump Web Component version to 5.7.4 #1121

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Bump Web Component version to 5.7.4 #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9d1284
Bump Web Component version to 5.7.2
tomivirkki Sep 21, 2020
0e6744e
Remove references to outer scroller
tomivirkki Sep 21, 2020
28e3f14
Bump Web Component version to 5.7.3
tomivirkki Sep 22, 2020
9512579
Bump Web Component version to 5.7.4
tomivirkki Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...sts/src/test/java/com/vaadin/flow/component/grid/it/GridTestScrollingOver100kLinesIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public void toStringIsUsedForObjectSerialization() {

GridElement grid = $(GridElement.class).first();

TestBenchElement scroller = grid.$("vaadin-grid-outer-scroller")
.id("outerscroller");
TestBenchElement scroller = grid.$("table").id("table");

// Scroll value that scrolls a bit further than the 100000th row to
// trigger the loading loop issue (vaadin-grid-flow issue #578)
Expand Down
2 changes: 1 addition & 1 deletion vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
*
*/
@Tag("vaadin-grid")
@NpmPackage(value = "@vaadin/vaadin-grid", version = "5.7.1")
@NpmPackage(value = "@vaadin/vaadin-grid", version = "5.7.4")
@JsModule("@vaadin/vaadin-grid/src/vaadin-grid.js")
@JsModule("@vaadin/vaadin-grid/src/vaadin-grid-column.js")
@JsModule("@vaadin/vaadin-grid/src/vaadin-grid-sorter.js")
Expand Down
1 change: 0 additions & 1 deletion vaadin-grid-flow/src/main/resources/META-INF/resources/frontend/gridConnector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,6 @@ import { ItemCache } from '@vaadin/vaadin-grid/src/vaadin-grid-data-provider-mix
grid.$connector.setVerticalScrollingEnabled = tryCatchWrapper(function(enabled) {
// There are two scollable containers in grid so apply the changes for both
setVerticalScrollingEnabled(grid.$.table, enabled);
setVerticalScrollingEnabled(grid.$.outerscroller, enabled);

// Since the scrollbars were toggled, there might have been some changes to layout
// size. Notify grid of the resize to ensure everything is in place.
Expand Down