fix: correctly show rows after showing hidden column and clearing grid filter #2200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When grid is used with an in-memory data provider with more than 50 items, after applying a filter and hiding a column and respectively making the column visible and filter cleared (in this particular order), grid breaks and it won't show items correctly unless page is refreshed.
The current fix simply resolves by checking for cell parent not being null in
__setColumnTemplateOrRenderer
method, and by doing so the issue is resolved. I have added a relevant test case which tests this particular behaviour.This PR is rebased on top of master (which includes all changes made into running tests)
Fixes vaadin/flow-components#2330
Type of change
Checklist
Additional for
Feature
type of change