Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: correctly show rows after showing hidden column and clearing grid filter #2200

Merged
merged 3 commits into from
Dec 21, 2021

Conversation

hdamr
Copy link
Contributor

@hdamr hdamr commented Nov 26, 2021

Description

When grid is used with an in-memory data provider with more than 50 items, after applying a filter and hiding a column and respectively making the column visible and filter cleared (in this particular order), grid breaks and it won't show items correctly unless page is refreshed.

The current fix simply resolves by checking for cell parent not being null in __setColumnTemplateOrRenderer method, and by doing so the issue is resolved. I have added a relevant test case which tests this particular behaviour.

This PR is rebased on top of master (which includes all changes made into running tests)

Fixes vaadin/flow-components#2330

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@hdamr hdamr force-pushed the fix/grid-filter-hide-column-2330 branch from d2ed1aa to ba89ee2 Compare December 16, 2021 10:10
@hdamr hdamr marked this pull request as ready for review December 16, 2021 11:15
@hdamr hdamr requested a review from sissbruecker December 16, 2021 11:20
src/vaadin-grid-column.html Outdated Show resolved Hide resolved
src/vaadin-grid-column.html Show resolved Hide resolved
@hdamr hdamr requested a review from web-padawan December 20, 2021 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid: removing the filter and make a hidden column visible simultaneously breaks the page
3 participants