fix: prevent overriding column hidden state when attaching column group (CP: 14.8) #2216
Conversation
…up (#3805) (CP: 14.8) Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible. Fixes vaadin/flow-components#2959 Cherry-pick of: vaadin/web-components#3805
| // no renderer or template needed in a hidden column | ||
| if (this.hidden) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
The PR seems to affect when the hidden state changes, so this condition was causing header templates not to render. The problem with this condition is that the observer does not listen to hidden changes, so even if the column / group becomes visible this is never called again. Adding hidden to the observer also didn't improve things, as there are some other checks that prevent setting the template.
The condition here was introduced as part of this bugfix: #2146. However it seems the fix was not covering all cases, so a another fix was added later: #2200. It seems that with the second fix the first one is not needed anymore, so it looks like we can remove it. The other concern is doing the extra work of rendering the cells even though they are hidden, though that was already the case before the first fix.
Fixes the column group to not synchronize its hidden state to child columns when it is attached, and visible.
Fixes vaadin/flow-components#2959
Cherry-pick of: vaadin/web-components#3805