Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(cleanup): Remove earn_stablecoin_config dynamic config #6305

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

finnian0826
Copy link
Contributor

Description

Title

Test plan

CI

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • N/A

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (144241a) to head (a0af8aa).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6305    +/-   ##
========================================
  Coverage   89.01%   89.02%            
========================================
  Files         739      739            
  Lines       31604    31603     -1     
  Branches     5571     5878   +307     
========================================
+ Hits        28132    28134     +2     
+ Misses       3427     3271   -156     
- Partials       45      198   +153     
Files with missing lines Coverage Δ
src/statsig/constants.ts 100.00% <ø> (ø)
src/statsig/types.ts 100.00% <ø> (ø)

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144241a...a0af8aa. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review December 5, 2024 21:40
@@ -8,8 +8,6 @@ import { navigate } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
import { RootState } from 'src/redux/reducers'
import { NETWORK_NAMES } from 'src/shared/conts'
import { getDynamicConfigParams } from 'src/statsig'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also remove the jest.mock('src/statsig')?

@finnian0826 finnian0826 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit c81521e Dec 6, 2024
15 checks passed
@finnian0826 finnian0826 deleted the finnian0826/act-1443-6 branch December 6, 2024 18:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants