Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(cleanup): Remove earn_stablecoin_config dynamic config #6305

Merged
merged 3 commits into from
Dec 6, 2024
Merged

chore(cleanup): Remove earn_stablecoin_config dynamic config #6305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
394a952
chore(cleanup): Remove earn_stablecoin_config dynamic config
finnian0826 Dec 4, 2024
0110939
feedback
finnian0826 Dec 6, 2024
a0af8aa
Merge branch 'main' into finnian0826/act-1443-6
finnian0826 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/statsig/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,6 @@ export const DynamicConfigs = {
rewardReminderDate: new Date(0).toISOString(),
},
},
[StatsigDynamicConfigs.EARN_STABLECOIN_CONFIG]: {
configName: StatsigDynamicConfigs.EARN_STABLECOIN_CONFIG,
defaultValues: {
providerName: 'Aave',
providerLogoUrl: '',
providerTermsAndConditionsUrl: '',
depositGasPadding: 0,
approveGasPadding: 0,
withdrawGasPadding: 0,
rewardsGasPadding: 0,
moreAavePoolsUrl: '',
},
},
[StatsigDynamicConfigs.APP_CONFIG]: {
configName: StatsigDynamicConfigs.APP_CONFIG,
defaultValues: {
Expand Down
1 change: 0 additions & 1 deletion src/statsig/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export enum StatsigDynamicConfigs {
CICO_TOKEN_INFO = 'cico_token_info',
WALLET_JUMPSTART_CONFIG = 'wallet_jumpstart_config',
NFT_CELEBRATION_CONFIG = 'nft_celebration_config',
EARN_STABLECOIN_CONFIG = 'earn_stablecoin_config',
APP_CONFIG = 'app_config',
EARN_CONFIG = 'earn_config',
}
Expand Down
15 changes: 0 additions & 15 deletions src/transactions/feed/TransactionDetailsScreen.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import { navigate } from 'src/navigator/NavigationService'
import { Screens } from 'src/navigator/Screens'
import { RootState } from 'src/redux/reducers'
import { NETWORK_NAMES } from 'src/shared/conts'
import { getDynamicConfigParams } from 'src/statsig'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also remove the jest.mock('src/statsig')?

import { StatsigDynamicConfigs } from 'src/statsig/types'
import TransactionDetailsScreen from 'src/transactions/feed/TransactionDetailsScreen'
import {
ClaimReward,
Expand Down Expand Up @@ -61,7 +59,6 @@ import {
} from 'test/values'

jest.mock('src/analytics/AppAnalytics')
jest.mock('src/statsig')

const mockAddress = '0x8C3b8Af721384BB3479915C72CEe32053DeFca4E'
const mockName = 'Hello World'
Expand Down Expand Up @@ -461,18 +458,6 @@ describe('TransactionDetailsScreen', () => {
describe('Earn', () => {
beforeEach(() => {
jest.clearAllMocks()
jest.mocked(getDynamicConfigParams).mockImplementation(({ configName, defaultValues }) => {
switch (configName) {
case StatsigDynamicConfigs.EARN_STABLECOIN_CONFIG:
return {
providerName: 'Aave',
providerLogoUrl: 'logoUrl',
providerTermsAndConditionsUrl: 'termsUrl',
}
default:
return defaultValues
}
})
})

it(`renders check status action for pending ${TokenTransactionTypeV2.EarnClaimReward} transaction`, () => {
Expand Down
Loading