Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): migrate react-native-fs to @divvi fork #6479

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

bakoushin
Copy link
Contributor

@bakoushin bakoushin commented Feb 4, 2025

Description

Migrate react-native-fs to the @divvi fork in order to get rid of the patch.

The patch changes are implemented in the fork:
itinance/react-native-fs@master...divvixyz:react-native-fs:master

Additional notes

This library is not maintained anymore, so we have to migrate to another one.

Possible alternatives (to consider in the future, as they aren't a drop-in replacement):

Test plan

  • CI
  • Next release App Store submission (patch is adding the PrivacyInfo.xcprivacy file)

Related issues

Backwards compatibility

Y

Network scalability

NA

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (4bcb306) to head (b46a09b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6479    +/-   ##
========================================
  Coverage   89.02%   89.02%            
========================================
  Files         729      729            
  Lines       31899    31899            
  Branches     6151     5829   -322     
========================================
  Hits        28397    28397            
  Misses       3454     3454            
  Partials       48       48            
Files with missing lines Coverage Δ
src/config.ts 96.26% <100.00%> (ø)
src/i18n/otaTranslations.ts 100.00% <100.00%> (ø)
src/qrcode/utils.ts 69.23% <100.00%> (ø)
src/utils/Logger.ts 65.67% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bcb306...b46a09b. Read the comment docs.

@bakoushin bakoushin marked this pull request as draft February 4, 2025 19:43
@bakoushin bakoushin marked this pull request as ready for review February 5, 2025 08:41
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@@ -12617,7 +12618,7 @@ react-native-flipper@^0.212.0:
resolved "https://registry.yarnpkg.com/react-native-flipper/-/react-native-flipper-0.212.0.tgz#b3fdd47676ecd09a25edd77a1466acace6276762"
integrity sha512-bDRfIgE3v/jjEEdnvGP0T6maDD+bXhDAQ/SZUYTKd/CQ6YIU1c0EF+e0urU62LNMv6XEFQKz226McdddyVhYZA==

react-native-fs@*, react-native-fs@^2.14.1, react-native-fs@^2.20.0:
react-native-fs@^2.14.1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which dep still references react-native-fs?
Would be good to only have one if possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it's redux-persist-fs-storage. Ok that's fine for now I guess.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the main point of the patch is to bring the iOS privacy manifest to the app. so I guess if it comes from the patched version, it will also serve for the unpatched one.

@bakoushin bakoushin added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 411b209 Feb 5, 2025
17 checks passed
@bakoushin bakoushin deleted the alex/divvi-react-native-fs branch February 5, 2025 09:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants