-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore(deps): migrate react-native-fs
to @divvi
fork
#6479
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6479 +/- ##
========================================
Coverage 89.02% 89.02%
========================================
Files 729 729
Lines 31899 31899
Branches 6151 5829 -322
========================================
Hits 28397 28397
Misses 3454 3454
Partials 48 48
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -12617,7 +12618,7 @@ react-native-flipper@^0.212.0: | |||
resolved "https://registry.yarnpkg.com/react-native-flipper/-/react-native-flipper-0.212.0.tgz#b3fdd47676ecd09a25edd77a1466acace6276762" | |||
integrity sha512-bDRfIgE3v/jjEEdnvGP0T6maDD+bXhDAQ/SZUYTKd/CQ6YIU1c0EF+e0urU62LNMv6XEFQKz226McdddyVhYZA== | |||
|
|||
react-native-fs@*, react-native-fs@^2.14.1, react-native-fs@^2.20.0: | |||
react-native-fs@^2.14.1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which dep still references react-native-fs?
Would be good to only have one if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it's redux-persist-fs-storage
. Ok that's fine for now I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the main point of the patch is to bring the iOS privacy manifest to the app. so I guess if it comes from the patched version, it will also serve for the unpatched one.
Description
Migrate
react-native-fs
to the@divvi
fork in order to get rid of the patch.The patch changes are implemented in the fork:
itinance/react-native-fs@master...divvixyz:react-native-fs:master
Additional notes
This library is not maintained anymore, so we have to migrate to another one.
Possible alternatives (to consider in the future, as they aren't a drop-in replacement):
Test plan
PrivacyInfo.xcprivacy
file)Related issues
Backwards compatibility
Y
Network scalability
NA