Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(deps): get rid of the react-native-fs patch #6480

Closed
wants to merge 1 commit into from

Conversation

bakoushin
Copy link
Contributor

@bakoushin bakoushin commented Feb 4, 2025

Description

The purpose of the patch was to add PrivacyInfo.xcprivacy which react-native-fs is lacking.

Another way to solve this issue is to patch the project's PrivacyInfo.xcprivacy directly, which is proposed in this PR.
Given the library is not maintained anymore, there is almost no risk that any of the privacy properties will suddenly change in the future.

Additional notes

This library is not maintained anymore, so we have to migrate to another one.

Possible alternatives (to consider in the future, as they aren't a drop-in replacement):

Test plan

  • CI
  • Next release App Store submission

Related issues

Backwards compatibility

Y

Network scalability

NA

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (f5f4a2c) to head (bfb2151).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6480   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files         729      729           
  Lines       31899    31899           
  Branches     6148     6151    +3     
=======================================
  Hits        28396    28396           
  Misses       3304     3304           
  Partials      199      199           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f4a2c...bfb2151. Read the comment docs.

@bakoushin
Copy link
Contributor Author

Closing in favor of #6479

@bakoushin bakoushin closed this Feb 5, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant