add enable_edge_node_externals #6562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
Linux Benchmark for 222e570Click to view benchmark
|
Linux Benchmark for 0972ee8Click to view benchmark
|
timneutkens
approved these changes
Nov 24, 2023
Comment on lines
+227
to
+237
| pub async fn supports_commonjs_externals(self: Vc<Self>) -> Result<Vc<bool>> { | ||
| let this = self.await?; | ||
| Ok(match this.execution { | ||
| ExecutionEnvironment::NodeJsBuildTime(..) | ExecutionEnvironment::NodeJsLambda(_) => { | ||
| Vc::cell(true) | ||
| } | ||
| ExecutionEnvironment::Browser(_) => Vc::cell(false), | ||
| ExecutionEnvironment::EdgeWorker(_) => Vc::cell(true), | ||
| ExecutionEnvironment::Custom(_) => todo!(), | ||
| }) | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub async fn supports_commonjs_externals(self: Vc<Self>) -> Result<Vc<bool>> { | |
| let this = self.await?; | |
| Ok(match this.execution { | |
| ExecutionEnvironment::NodeJsBuildTime(..) | ExecutionEnvironment::NodeJsLambda(_) => { | |
| Vc::cell(true) | |
| } | |
| ExecutionEnvironment::Browser(_) => Vc::cell(false), | |
| ExecutionEnvironment::EdgeWorker(_) => Vc::cell(true), | |
| ExecutionEnvironment::Custom(_) => todo!(), | |
| }) | |
| } | |
| pub fn supports_commonjs_externals(&self) -> Vc<bool> { | |
| match self.execution { | |
| ExecutionEnvironment::NodeJsBuildTime(..) | ExecutionEnvironment::NodeJsLambda(_) => { | |
| Vc::cell(true) | |
| } | |
| ExecutionEnvironment::Browser(_) => Vc::cell(false), | |
| ExecutionEnvironment::EdgeWorker(_) => Vc::cell(true), | |
| ExecutionEnvironment::Custom(_) => todo!(), | |
| } | |
| } |
would love a linter for this
AhmedBaset
pushed a commit
to AhmedBaset/next.js
that referenced
this pull request
Nov 26, 2023
### What? Edge runtime allow additional node.js builtins see vercel/turborepo#6562 Closes PACK-2031 --------- Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Some edge runtimes allow additional node.js builtins ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2030
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Some edge runtimes allow additional node.js builtins ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2030
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Some edge runtimes allow additional node.js builtins ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2030
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Some edge runtimes allow additional node.js builtins ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2030
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some edge runtimes allow additional node.js builtins
Testing Instructions
Closes PACK-2030