Updating the react select #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README - fix typo and improve prop list
Accept promises in `asyncOptions` alongside callbacks
Function doesn’t need to be created on every render
Docs update for `asyncOptions` plus "nicety"
IE-fix: don't blur if document.activeElement is menuDOM
Fix math operations to use less --strict-math=on
Convert LESS to SCSS using the less2sass gem. Fix references to some mixins in the individual scss files, and allow the importing of the variables separately from the components so an end user can override the variables before use.
Clear search input on blur
Conflicts: src/Option.js
Convert LESS to SCSS and re-organise
Fix failing Value.js tests
This essentially reverts the change made here #595 By applying a tabIndex on a div element allows it to be focused. This was the reason the div was changed to an input, by putting it back to a div mobile devices display consistent behaviour when the select box recieves focus. IOS would display a chrome at the bottom of the page where as chrome wouldn't.
If a select box was activated near the bottom of the viewport, the viewport will now shift the minimum amount to display the full contents of the menu.
+ the first few tests for Select.Async, using the shallow renderer + removed redundant asyncOptions tests from Select-test + Changes Select.Async thenPromise to return the resulting promise if handled with promises - no change to usage, but makes testing easier as it is possible to just wait for the returned promise from thenPromise to complete before asserting the changes. + Added dev dependency to unexpected-react, to ease testing with the shallow renderer
Documented in the test case Changed the cache checking to start with the full search string, and then decrease the length.
The DOM is still needed for the other tests, and `npm test` may run the async tests first. This means React is already required, and has already decided that there is no DOM, hence `TestUtils.renderIntoDocument` won't work. Adding the DOM emulation to Async-test fixes this problem.
Treats as if the options list was empty
Async tests
Change input back to div
as well as adding the feature to the README
- From `dist/default.css` to `dist/react-select.min.css`
Fixing a problem where the border isn't showing when the element is inside a table.
Was referencing default.css which doesn't exist
…ct nodes
Remove the warning without modifying the functionality by using
React.PropTypes.oneOfType([
React.PropTypes.string,
React.PropTypes.node
])
instead of
React.PropTypes.string,
Less strict PropTypes for string placeholders to optionally allow React nodes
Fix style path
Fix a problem with border inside table
Feature to scroll the viewport to display the menu
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.