This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Decouple muted and vol=0 to allow muting/unmuting the player correctly #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
Jun 20, 2017
Merged
6 tasks
gkatsev
approved these changes
Jul 19, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting as a possible means to address #226 where muted() is dependent on volume level.
This change adds a _muted property and gets/sets it based on the value passed in. If true, it still sets volume to 0 when muting but also sets _lastVolume so we can restore correctly. Also sets volume back to _lastVolume when un-muting.
Tested on Chrome 58.0.3029.110