adjust volume ranges so muted(true) and vol=0 do not use the same icons #4425
Conversation
| @@ -81,11 +81,11 @@ class MuteToggle extends Button { | |||
| const vol = this.player_.volume(); | |||
| let level = 3; | |||
|
|
|||
| if (vol === 0 || this.player_.muted()) { | |||
| if (this.player_.muted()) { | |||
There was a problem hiding this comment.
what about only making this change?
I think level 1 is supposed to imply that the volume is very low and not just 0. So, if muted, level 0, if <0.33, level 1, if less than .67 level 2, else level 3?
There was a problem hiding this comment.
That works for me. Only reason I changed the other levels is because I thought no ring seems like a good indicator for 0 sound, 1 ring for up to 50% and two rings for over 50%
|
I'm in two minds about this. It does make sense to have some UI change when muting a player with zero volume so it doesn't appear that nothing has happened, but it might cause confusion if a user thinks the slider isn't getting all the way to zero when they drag it to the left. It does illustrate that the v6 behaviour is a big improvement in UX. |
|
The fact that volume 0 and muted are separate is kind of weird from a UI perspective. Kind of makes sense from an implementation perspective, though. @marguinbc made a PR to make the swf behave like the video element does wrt muted and volume (videojs/video-js-swf#230). |
|
I'd go with this on balance. I've been following the work on the swf, great improvement. |
Description
Potential fix for #4424
Specific Changes proposed
Change the volume levels used to select the videojs-icon-volume-* classes so muted(true) and volume(0) do not use the same icon. Fixes an issue where sliding the volume slider to 0 has the appearance of setting muted(true) but toggling the mute-toggle/volumeMenuButton does not restore the volume. Only setting the volume using the slider removes the muted icon appearance.
Requirements Checklist