Remove additional props being forward to the DOM (#234)

This PR #228 removed the format prop from being forward. Somehow these props were getting through 🤔. Co-authored-by: Kenneth Duverge <kenneth.duverge@vimeo.com>
vimeo · Mar 2, 2023 · c722278 · c722278
1 parent be00f36
commit c722278
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/components/Button/Button.style.ts b/src/components/Button/Button.style.ts
@@ -41,7 +41,14 @@ export const ButtonChildren = styled.span<any>`
 `;
 
 export const ButtonStyled = styled.button.withConfig<any>({
-  shouldForwardProp: (prop: any) => !['format'].includes(prop),
+  shouldForwardProp: (prop: any) =>
+    ![
+      'format',
+      'icononly',
+      'iconposition',
+      'theme',
+      'variant',
+    ].includes(prop),
 })`
   ${buttonCore};
   ${buttonIcon};