Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Remove Additional Button Props From Being Forwarded #234

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

kenneth-duverge
Copy link
Collaborator

@kenneth-duverge kenneth-duverge commented Mar 1, 2023

Related to:
#228

What this PR does

Adds additional props that should NOT forward to the DOM element

image

Testing

N/A

This PR #228 removed the format prop from being forward. Somehow these props were getting through 🤔.
@kenneth-duverge kenneth-duverge marked this pull request as ready for review March 1, 2023 16:24
@kenneth-duverge kenneth-duverge requested review from a team as code owners March 1, 2023 16:24
Copy link
Collaborator

@juliewongbandue juliewongbandue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kenneth-duverge kenneth-duverge merged commit c722278 into main Mar 2, 2023
@kenneth-duverge kenneth-duverge deleted the update-button-prop-forwarding branch March 2, 2023 23:58
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants