Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[V1] Improve Error Message for Unsupported Config #12535

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[V1] Improve Error Message for Unsupported Config #12535

merged 4 commits into from
Jan 29, 2025

Conversation

robertgshaw2-redhat
Copy link
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Jan 29, 2025 •
edited by github-actions bot
Loading

SUMMARY:

  • improve error message for unsupported config on V1

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 29, 2025
@robertgshaw2-redhat robertgshaw2-redhat changed the title [V1] Improve Error Message for [V1] Improve Error Message for Unsupported Config Jan 29, 2025
@robertgshaw2-redhat robertgshaw2-redhat mentioned this pull request Jan 29, 2025
Closed
1 task
mgoin
mgoin approved these changes Jan 29, 2025
View reviewed changes
robertgshaw2-redhat and others added 2 commits January 28, 2025 21:20
@robertgshaw2-redhat @mgoin
Update vllm/platforms/cuda.py
f78d463 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
@robertgshaw2-redhat @mgoin
Update vllm/platforms/cuda.py
37073ce 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) January 29, 2025 02:20
@robertgshaw2-redhat robertgshaw2-redhat merged commit 5f671cb into main Jan 29, 2025
46 checks passed
@robertgshaw2-redhat robertgshaw2-redhat deleted the improve-error-message branch January 29, 2025 04:56
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
@robertgshaw2-redhat @mgoin @rasmith
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
54f55a2 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@robertgshaw2-redhat @mgoin @Isotr0py
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
7c7bc34 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Signed-off-by: Isotr0py <2037008807@qq.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
@robertgshaw2-redhat @mgoin @NickLucche
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
570889d 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
@robertgshaw2-redhat @mgoin @ShangmingCai
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
4ea2cda 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
@robertgshaw2-redhat @mgoin @GWS0428
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
c318ba0 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
@robertgshaw2-redhat @mgoin @panf2333
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
46332b2 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@robertgshaw2-redhat @mgoin @kerthcet
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
951805c 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
@robertgshaw2-redhat @mgoin @lk-chen
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
63bf661 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar pushed a commit to Said-Akbar/vllm-rocm that referenced this pull request Mar 7, 2025
@robertgshaw2-redhat @mgoin @Said-Akbar
[V1] Improve Error Message for Unsupported Config (vllm-project#12535)
d913efe 
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Signed-off-by: saeediy <saidakbarp@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@mgoin mgoin mgoin approved these changes

@comaniac comaniac comaniac approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertgshaw2-redhat @tlrmchlsmth @mgoin @comaniac @jeejeelee