Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[V1] Improve Error Message for Unsupported Config #12535

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[V1] Improve Error Message for Unsupported Config #12535

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d57f3f
updated
robertgshaw2-redhat Jan 29, 2025
f78d463
Update vllm/platforms/cuda.py
robertgshaw2-redhat Jan 29, 2025
37073ce
Update vllm/platforms/cuda.py
robertgshaw2-redhat Jan 29, 2025
d110ff6
updated
robertgshaw2-redhat Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions vllm/platforms/cuda.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,17 @@ def check_and_update_config(cls, vllm_config: VllmConfig) -> None:
if parallel_config.worker_cls == "auto":
if scheduler_config.is_multi_step:
if envs.VLLM_USE_V1:
raise NotImplementedError
raise NotImplementedError(
"Multi-step scheduling is not supported (and not "
"needed) on VLLM V1. Please Launch without "
"--num-scheduler-steps.")
else:
parallel_config.worker_cls = \
"vllm.worker.multi_step_worker.MultiStepWorker"
elif vllm_config.speculative_config:
if envs.VLLM_USE_V1:
raise NotImplementedError
raise NotImplementedError(
"Speculative decoding is not yet support on VLLM V1.")
else:
parallel_config.worker_cls = \
"vllm.spec_decode.spec_decode_worker.create_spec_worker"
Expand Down