Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix context-scoped plugins not getting installed after creating management-cluster f… #2287

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix context-scoped plugins not getting installed after creating management-cluster f… #2287

merged 1 commit into from
May 4, 2022

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented May 3, 2022 •
edited
Loading

…rom UI

What this PR does / why we need it

  • Fix plugins not getting installed after creating management-cluster from UI

Which issue(s) this PR fixes

Fixes #2293

Describe testing done for PR

Create management-cluster using UI and make sure context-scoped plugins gets installed

Screen Shot 2022-05-03 at 1 55 22 PM

Release note

Fix context-scoped plugins not getting installed after creating management-cluster through Kickstart UI

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested review from a team as code owners May 3, 2022 17:49
@anujc25 anujc25 changed the title Fix plugins not getting installed after creating management-cluster f… Fix context-scoped plugins not getting installed after creating management-cluster f… May 3, 2022
@github-actions
Copy link

github-actions bot commented May 3, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2287/20220503180040/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

saji-pivotal
saji-pivotal approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@saji-pivotal saji-pivotal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tenczar
tenczar approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@tenczar tenczar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imikushin imikushin added the ok-to-merge PRs should be labelled with this before merging label May 3, 2022
imikushin
imikushin approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vuil
vuil approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anujc25 anujc25 merged commit 135312e into vmware-tanzu:main May 4, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@saji-pivotal saji-pivotal saji-pivotal approved these changes

@vuil vuil vuil approved these changes

@tenczar tenczar tenczar approved these changes

@imikushin imikushin imikushin approved these changes

Assignees
No one assigned
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context-scoped plugins not getting installed after creating management-cluster through UI
6 participants
@anujc25 @imikushin @tenczar @vuil @saji-pivotal @vmwclabot