Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Plumb legacy skipCNIBinaries config to CalicoConfig API #2774

Merged

Conversation

12345lcr
Copy link
Contributor

@12345lcr 12345lcr commented Jun 28, 2022

What this PR does / why we need it

Plumb legacy skipCNIBinaries config to CalicoConfig API

#@ if/end data.values.PROVIDER_TYPE != "docker":
skipCNIBinaries: true

Which issue(s) this PR fixes

Fixes: #2370, #2415

Describe testing done for PR

Release note

Plumb legacy skipCNIBinaries config to CalicoConfig API

PR Checklist

  • Squash the commits into one or a small number of logical commits
  • Use good commit messages
  • Ensure PR contains terms all contributors can understand and links all contributors can access

Additional information

Special notes for your reviewer

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/2774/20220628092546/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #2774 (ab200dd) into main (50594bf) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
+ Coverage   43.40%   43.42%   +0.01%     
==========================================
  Files         410      410              
  Lines       40665    40665              
==========================================
+ Hits        17650    17657       +7     
+ Misses      21363    21359       -4     
+ Partials     1652     1649       -3     
Impacted Files Coverage Δ
cmd/cli/plugin/tkr/v1alpha3/os.go 73.50% <0.00%> (-0.86%) ⬇️
addons/controllers/clusterbootstrap_controller.go 69.27% <0.00%> (+0.54%) ⬆️
pkg/v1/tkg/tkgpackageclient/package_update.go 85.00% <0.00%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50594bf...ab200dd. Read the comment docs.

@12345lcr 12345lcr added the needs-triage Indicates an issue or PR needs to be triaged label Jul 4, 2022
@shyaamsn
Copy link
Contributor

shyaamsn commented Aug 4, 2022

LGTM. @vmware-tanzu/tanzu-framework-reviewers Could you please review/approve this PR. It has been pending for a long time.

@vijaykatam
Copy link
Contributor

Change looks good. Do we need to backport to release-0.25/Fuji release?

@vijaykatam
Copy link
Contributor

Could you also add release note prior to merging?

@12345lcr
Copy link
Contributor Author

12345lcr commented Aug 8, 2022

Thanks @vijaykatam , release note updated. The downstream JIRA indicate that this fix is part of G release.

@12345lcr 12345lcr added the ok-to-merge PRs should be labelled with this before merging label Aug 15, 2022
@12345lcr 12345lcr merged commit d91e6d8 into vmware-tanzu:main Aug 15, 2022
12345lcr added a commit that referenced this pull request Aug 15, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
area/addons cla-not-required needs-triage Indicates an issue or PR needs to be triaged ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plumb Calico CLI addon configs to CalicoConfig API
4 participants