Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Default deploy-in-cluster-ipam-provider to true #4155

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

flawedmatrix
Copy link
Contributor

@flawedmatrix flawedmatrix commented Dec 13, 2022

What this PR does / why we need it

Enables the deploy in-cluster ipam provider feature flag by default and remove the beta suffix.

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Deployed a management cluster locally and see the caip-in-cluster-controller-manager was deployed successfully and by default.

Release note

The `features.management-cluster.deploy-in-cluster-ipam-provider` feature flag is now enabled by default.

Additional information

Special notes for your reviewer

@flawedmatrix
Copy link
Contributor Author

/test install-vc7

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4155/20221213001051/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@alfredthenarwhal
Copy link
Collaborator

@flawedmatrix: /test install-vc7
Commit: 1e96e1e

Build failed! Build no: 3571

@christianang
Copy link
Contributor

/test install-vc7

@alfredthenarwhal
Copy link
Collaborator

@christianang: /test install-vc7
Commit: 1e96e1e

Build failed! Build no: 3586

- Enabled deploy in-cluster ipam provider feature flag by default and
  remove the beta suffix.

Co-authored-by: Christian Ang <angc@vmware.com>
@christianang christianang force-pushed the make-node-ipam-default branch from 1e96e1e to c3dc0f4 Compare December 13, 2022 18:16
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/4155/20221213182551/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #4155 (c3dc0f4) into main (bf4d2b4) will decrease coverage by 0.88%.
The diff coverage is 72.83%.

@@            Coverage Diff             @@
##             main    #4155      +/-   ##
==========================================
- Coverage   48.67%   47.78%   -0.89%     
==========================================
  Files         446      476      +30     
  Lines       44279    46399    +2120     
==========================================
+ Hits        21553    22172     +619     
- Misses      20686    22135    +1449     
- Partials     2040     2092      +52     
Impacted Files Coverage Δ
...i/plugin/isolated-cluster/imageop/client_imgpkg.go 0.00% <0.00%> (ø)
...gin/isolated-cluster/imageop/publishimagestotar.go 59.69% <74.68%> (ø)
cmd/cli/plugin/tkr/v1alpha3/os.go 73.50% <0.00%> (-0.86%) ⬇️
cmd/cli/plugin/isolated-cluster/main.go 0.00% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/upgrade.go 58.94% <0.00%> (ø)
cmd/cli/plugin/cluster/set_node_pool.go 14.63% <0.00%> (ø)
cmd/cli/plugin/cluster/list.go 11.36% <0.00%> (ø)
cmd/cli/plugin/cluster/set_machinehealthcheck.go 23.33% <0.00%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christianang
Copy link
Contributor

/test install-vc7

@alfredthenarwhal
Copy link
Collaborator

@christianang: /test install-vc7
Commit: c3dc0f4

Tests failed! Build no: 3591

Copy link
Contributor

@imikushin imikushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianang christianang added the ok-to-merge PRs should be labelled with this before merging label Dec 14, 2022
@christianang christianang merged commit ef386ea into vmware-tanzu:main Dec 14, 2022
@christianang christianang deleted the make-node-ipam-default branch December 14, 2022 21:52
wenqiq pushed a commit to wenqiq/tanzu-framework that referenced this pull request Dec 20, 2022
- Enabled deploy in-cluster ipam provider feature flag by default and
  remove the beta suffix.

Co-authored-by: Christian Ang <angc@vmware.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants