-
Notifications
You must be signed in to change notification settings - Fork 192
Default deploy-in-cluster-ipam-provider to true #4155
Default deploy-in-cluster-ipam-provider to true #4155
Conversation
/test install-vc7 |
Cluster Generation A/B Results: |
Build failed! Build no: 3571 |
/test install-vc7 |
Build failed! Build no: 3586 |
- Enabled deploy in-cluster ipam provider feature flag by default and remove the beta suffix. Co-authored-by: Christian Ang <angc@vmware.com>
1e96e1e
to
c3dc0f4
Compare
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #4155 +/- ##
==========================================
- Coverage 48.67% 47.78% -0.89%
==========================================
Files 446 476 +30
Lines 44279 46399 +2120
==========================================
+ Hits 21553 22172 +619
- Misses 20686 22135 +1449
- Partials 2040 2092 +52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test install-vc7 |
Tests failed! Build no: 3591 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Enabled deploy in-cluster ipam provider feature flag by default and remove the beta suffix. Co-authored-by: Christian Ang <angc@vmware.com>
What this PR does / why we need it
Enables the deploy in-cluster ipam provider feature flag by default and remove the beta suffix.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Deployed a management cluster locally and see the
caip-in-cluster-controller-manager
was deployed successfully and by default.Release note
Additional information
Special notes for your reviewer