This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
generate binaries for darwin-arm64 and linux-arm64 #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would have labeled the PR, however I am not a contributor and thus I cannot label. I would suggest a label of |
joefitzgerald
force-pushed
the
jf-add-darwin-arm64
branch
from
4d35e48 to
25a7565
Compare
Signed-off-by: Joe Fitzgerald <jfitzgerald@vmware.com>
joefitzgerald
force-pushed
the
jf-add-darwin-arm64
branch
from
25a7565 to
c66fcdb
Compare
joefitzgerald
changed the title
joefitzgerald
changed the title
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Fitzgerald jfitzgerald@vmware.com
What this PR does / why we need it: Adds
darwin-arm64andlinux-arm64architecture to build binaries that will work on these OS/architecture pairs. While theamd64binaries will run ondarwinusing Rosetta, it is preferable to avoid this emulation.Which issue(s) this PR fixes: Not sure it completely fixes any existing issues, but is related to #35, #440, and #855.
Describe testing done for PR: Ran
make release.Special notes for your reviewer: N/A
Does this PR introduce a user-facing change?:
New PR Checklist