Replace camptocamp/archive with puppet-community/puppet-archive #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'verbose' attribute of the archive::download resource defaults to true. This causes a notice message, 'no checksum for this archive', to be spammed to the terminal when archive::download is called without setting the checksum attribute. This commit suppresses this notice.
update .fixtures.yml with correct module change name of resource from archive::download to archive update spec test, removing archive__download, updating resource title to include full path update file to require archive, not archive::download
|
I thought I had a posted a comparison of the various options to a previous issue but I can't seem to locate it. Anyways, I believe the biggest show stopper issues for moving to puppet-community/archive are listed here: #340 (comment) |
|
puppet/archive (and this PR) now has checksum and proxy support, so perhaps moving to it is feasible? |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
Handle expected proxy format. Handle no checksum
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces camptocamp/archive with puppet-community/puppet-archive. There are other modules which use puppet-community/puppet-archive and this resolves the module namespace conflict.