use puppet/archive for all file downloads #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mmarseglia @rvincentatprokarmadotcom @xaniasd @elkangaroo @mheiges @sfhardman @madAndroid |
|
I think I've found an issue that needs to be fixed before this is ready-to-merge. |
|
make that two problems... |
jhoblitt
force-pushed
the
feature/puppet-archive
branch
from
ad477e4 to
755c0c4
Compare
|
one fixed... at least one to go... |
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
jhoblitt
force-pushed
the
feature/puppet-archive
branch
from
755c0c4 to
b525210
Compare
|
@rtyler Assuming CI passes, this should be ready for merge. |
|
hmm, maybe not... |
|
I'm apparently bi-polar today. This is working at least as well as it was before but the magic returning core plugins issue is still present. It is ready for merge. |
jhoblitt
force-pushed
the
feature/puppet-archive
branch
from
b525210 to
36cf67c
Compare
- update .fixtures.yml with correct module - change name of resource from archive::download to archive - update spec test, removing archive__download, updating resource title to include full path - update file to require archive, not archive::download
puppetcommunity -> voxpupuli
This defined type was missed in the big voxpupuli#473 cleanup.
replaced by puppet/archive
replaced with a puppet/archive resource.
This variable has the proxy server / port in the format expected by puppet/archive.
jhoblitt
force-pushed
the
feature/puppet-archive
branch
from
36cf67c to
49fc309
Compare
|
I find this change to be agreeable. |
rtyler
pushed a commit
that referenced
this pull request
Mar 4, 2016
use puppet/archive for all file downloads
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the use of:
camptocamp/archivenanliu/stagingexecresources usingwgetorcurlcloses #340 (supersedes)
resolves #427
closes #433 (supersedes)
resolves #505
possibly related to #512