Add test for accepting array as parameter based on wsdl #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v. 0.19.0 broke giving array as a parameter. It would now accept the "array"
with invalid syntax like this: {input: {PeriodList: {"PeriodType[]": {PeriodId: '1'}}}}
i.e. it wants the "[]" as the parameter name and it does not accept an array, but an
object. The invalid syntax then prints invalid XML like this:
"<PeriodList><PeriodType[]><PeriodId>1</PeriodId></PeriodType[]></PeriodList>"
This test shows old and correct syntax.
This test passes if you revert commit 5dbcb1d
or disable if statement mentioned in
vpulim#914 (review)
herom
added a commit
to herom/node-soap
that referenced
this pull request
May 29, 2017
…new behaviour in vpulim#914)
herom
added a commit
to herom/node-soap
that referenced
this pull request
May 29, 2017
…new behaviour in vpulim#914)
herom
added a commit
to herom/node-soap
that referenced
this pull request
May 29, 2017
…new behaviour in vpulim#914)
jcald1
pushed a commit
to jcald1/node-soap
that referenced
this pull request
Jun 8, 2017
v. 0.19.0 broke giving array as a parameter. It would now accept the "array"
with invalid syntax like this: {input: {PeriodList: {"PeriodType[]": {PeriodId: '1'}}}}
i.e. it wants the "[]" as the parameter name and it does not accept an array, but an
object. The invalid syntax then prints invalid XML like this:
"<PeriodList><PeriodType[]><PeriodId>1</PeriodId></PeriodType[]></PeriodList>"
This test shows old and correct syntax.
This test passes if you revert commit 5dbcb1d
or disable if statement mentioned in
vpulim#914 (review)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v. 0.19.0 broke giving array as a parameter. It would now accept the "array"
with invalid syntax like this: {input: {PeriodList: {"PeriodType[]": {PeriodId: '1'}}}}
i.e. it wants the "[]" as the parameter name and it does not accept an array, but an
object. The invalid syntax then prints invalid XML like this:
"<PeriodType[]>1</PeriodType[]>"
This test shows old and correct syntax.
This test passes if you revert commit 5dbcb1d
or disable if statement mentioned in
#914 (review)