Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

upgrade to lodash 4.17.4 #936

Closed
wants to merge 2 commits into from
Closed

upgrade to lodash 4.17.4 #936

wants to merge 2 commits into from

Conversation

rflament
Copy link
Contributor

Lodash 4.x merge function does not take customizer function as the third argument anymore :

https://lodash.com/docs/4.17.4#merge

Instead we have to use the function mergeWith

That's problematic when a dependency other than node-soap requires lodash 4.x : lodash 4.x ends up being used and wsdl inclusion does not work anymore.

This pull request switches to lodash 4.17.4 and use mergeWith function to fix this.

@coveralls
Copy link

coveralls commented May 30, 2017

Coverage Status

Coverage remained the same at 93.191% when pulling 10c7990 on rflament:master into 94a8b54 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented May 30, 2017

please fix the code so the tests pass

@herom
Copy link
Contributor

herom commented May 31, 2017

@jsdevel the test which are failing are the ones that we merged in with #933

@rflament could you please rebase your branch so that it's on par with the latest master (with #937 merged in) - the test should pass afterwards 👍

@coveralls
Copy link

coveralls commented May 31, 2017

Coverage Status

Coverage remained the same at 93.215% when pulling 189af72 on rflament:master into d3f9875 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented May 4, 2018

closing due to inactivity

@jsdevel jsdevel closed this May 4, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants