-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(language-core): try handle node next module resolution #3159
Conversation
cfd430d
to
9da85c6
Compare
this only seems to pass on the master branch, not sure what it is at this point and I don't think its needed to get this out right away since I personally decided to move to the bundler resolution anyway |
9da85c6
to
a15d198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will test in my project for this PR.
…ution cache instead of process.cwd
@yoyo930021 changes look neat, have you tested it in a real project? |
You can revert master merge and I'll handle it, it can't just resolve in this PR. |
a0e30ae
to
a848b46
Compare
okay, undid my master merge and yea quickly realize there was some typing problems. Looks like the problem still exists on the action checks? Seems fine locally so guessing the volar package change and is probably what you were referring to what you needed to resolve? Otherwise should be all cleaned up now with request changes. |
This is difficult to solve in this repo, may need to move to https://github.com/volarjs/volar.js/blob/master/packages/typescript/src/languageServiceHost.ts, will continue to investigate. |
Hey @kalvenschraut, I can't push commit to RTVision:node-next-resolution branch, can you check permissions? |
I know on newer pull requests I make there is a checkbox to allow the maintainers to do this, not sure how I can retroactively give permission. Best thing I could find is inviting you as a collaborator on the fork. |
Thanks! |
These are the changes I mentioned in #2662 in my last comment.
If direction is to not support node next then this PR can be closed and disregarded.