-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Typo in PrimaryCommandBufferAbstract
docs?
#2129
Comments
5 tasks
Yeah that looks like a mistake, it should be |
thanatos
added a commit
to thanatos/vulkano
that referenced
this issue
Feb 20, 2023
Rua
pushed a commit
that referenced
this issue
Mar 2, 2023
* Minor touch-ups to the docs for `PrimaryCommandBufferAbstract` * Rewrite this passage to address the comments in #2129
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this issue
Feb 20, 2024
…no-rs#2128) * Minor touch-ups to the docs for `PrimaryCommandBufferAbstract` * Rewrite this passage to address the comments in vulkano-rs#2129
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Template
If you dont understand something just leave it.
If you can provide more detailed information than the template allows for, please ignore the template and present all of your findings.
main.rs
file that demonstrates the issue: N/AIssue
The docs for
PrimaryCommandBufferAbstract::execute
, as well asPrimaryCommandBufferAbstract::execute_after
read:There doesn't seem to be any method
then_signal_future
; this is probably meant to refer to one or all of thethen_signal_fence(_*)
orthen_signal_semaphore(_*)
methods.(There's also some grammatical errors towards the end of the paragraph; I've sent #2128 for those. However, I'm not sure how the bits around "
then_signal_future
are supposed to read, so I didn't fix those, and hence, put that in this issue.)The text was updated successfully, but these errors were encountered: