Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor touch-ups to the docs for PrimaryCommandBufferAbstract #2128

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

thanatos
Copy link
Contributor

@thanatos thanatos commented Jan 14, 2023

  1. Update documentation to reflect any user-facing changes - in this repository.

  2. Make sure that the changes are covered by unit-tests.

  3. Run cargo fmt on the changes.

  4. Please put changelog entries in the description of this Pull Request
    if knowledge of this change could be valuable to users. No need to put the
    entries to the changelog directly, they will be transferred to the changelog
    file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  5. Describe in common words what is the purpose of this change, related
    Github Issues, and highlight important implementation aspects.

Relates to #2129, in that there's another error in this paragraph that I couldn't fix.

@Rua
Copy link
Contributor

Rua commented Feb 16, 2023

@thanatos do you still want this merged? If so, could you address my comment in #2129?

@thanatos
Copy link
Contributor Author

Thanks for the poke, @Rua. I've taken a stab at re-writing the section to address #2129.

@Rua Rua merged commit 52748c6 into vulkano-rs:master Mar 2, 2023
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
…no-rs#2128)

* Minor touch-ups to the docs for `PrimaryCommandBufferAbstract`

* Rewrite this passage to address the comments in vulkano-rs#2129
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants