Skip to content

Commit

Permalink
fix[venom]: remove dominator tree invalidation for store elimination …
Browse files Browse the repository at this point in the history
…pass (#4069)

Each pass has the responsibility of invalidating analyses that it affects according 
to the changes it introduces. 

The `StoreEliminationPass` should not invalidate the `DominatorTree`
  • Loading branch information
harkal authored May 31, 2024
1 parent 3371956 commit 7b0ee5f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions vyper/venom/passes/store_elimination.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
from vyper.venom.analysis.cfg import CFGAnalysis
from vyper.venom.analysis.dfg import DFGAnalysis
from vyper.venom.analysis.dominators import DominatorTreeAnalysis
from vyper.venom.analysis.liveness import LivenessAnalysis
from vyper.venom.basicblock import IRVariable
from vyper.venom.passes.base_pass import IRPass
Expand All @@ -27,7 +26,6 @@ def run_pass(self):
continue
self._process_store(dfg, inst, var, inst.operands[0])

self.analyses_cache.invalidate_analysis(DominatorTreeAnalysis)
self.analyses_cache.invalidate_analysis(LivenessAnalysis)
self.analyses_cache.invalidate_analysis(DFGAnalysis)

Expand Down

0 comments on commit 7b0ee5f

Please # to comment.