Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix[venom]: remove dominator tree invalidation for store elimination pass #4069

Merged

Conversation

harkal
Copy link
Collaborator

@harkal harkal commented May 31, 2024

What I did

Removed unnecessary dominator tree invalidation in StoreEliminations pass

How I did it

How to verify it

Commit message

Each pass has the responsibility of invalidating analyses that it affects according 
to the changes it introduces. 

The `StoreEliminationPass` should not invalidate the `DominatorTree`

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (3371956) to head (9b3a2b5).

Current head 9b3a2b5 differs from pull request most recent head 76b4ba8

Please upload reports for the commit 76b4ba8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4069      +/-   ##
==========================================
- Coverage   91.25%   88.70%   -2.55%     
==========================================
  Files         108      108              
  Lines       15522    15521       -1     
  Branches     3410     3410              
==========================================
- Hits        14164    13768     -396     
- Misses        926     1242     +316     
- Partials      432      511      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harkal harkal marked this pull request as ready for review May 31, 2024 12:13
@charles-cooper charles-cooper changed the title fix[venom]: remove DominatorTree invalidation for StoreElimination pass fix[venom]: remove dominator tree invalidation for store elimination pass May 31, 2024
@charles-cooper charles-cooper enabled auto-merge (squash) May 31, 2024 12:16
@charles-cooper charles-cooper merged commit 7b0ee5f into vyperlang:master May 31, 2024
156 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants