Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix[tool]: keep experimentalCodegen blank in standard json input #4216

Merged

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Aug 31, 2024

What I did

How I did it

How to verify it

Commit message

in standard json input, `experimentalCodegen` would default
to true, creating a conflict if the user used `#pragma
experimental-codegen`. set it to `None`.

misc/refactor:
- refactor `get_settings` function.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper added this to the v0.4.1 milestone Sep 1, 2024
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.14%. Comparing base (f909d6e) to head (cd4ae4a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vyper/cli/vyper_json.py 28.57% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f909d6e) and HEAD (cd4ae4a). Click for more details.

HEAD has 139 uploads less than BASE
Flag BASE (f909d6e) HEAD (cd4ae4a)
140 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4216       +/-   ##
===========================================
- Coverage   91.35%   46.14%   -45.22%     
===========================================
  Files         109      109               
  Lines       15635    15637        +2     
  Branches     3443     3443               
===========================================
- Hits        14283     7215     -7068     
- Misses        920     7867     +6947     
- Partials      432      555      +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title fix[tool]: keep experimental_codegen blank in standard json input fix[tool]: keep experimentalCodegen blank in standard json input Sep 1, 2024
@charles-cooper charles-cooper merged commit 9a208a6 into vyperlang:master Sep 1, 2024
158 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants