Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Include Trend Reports table on reports page #1092

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented May 9, 2024

Address #1083 and implements the design shared in #963 (comment).

This PR adds a versions summary and results table on the final reports page (AT + Browser report page): /reports/<id>/targets/<id>

@howard-e howard-e changed the title Trends table feat: Include Trend Reports table on reports page May 9, 2024
@howard-e howard-e marked this pull request as ready for review May 9, 2024 16:09
@howard-e howard-e requested review from alflennik and gnarf May 9, 2024 16:18
Copy link
Contributor

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty simple and straight forward. 👍

Might be worth adding some simple tests for things like only showing for recommended reports, but I wouldn't necessarily block on this

@ccanash ccanash removed the request for review from alflennik May 16, 2024 15:44
@howard-e
Copy link
Contributor Author

Might be worth adding some simple tests for things like only showing for recommended reports, but I wouldn't necessarily block on this

Thanks! Will follow this up in another PR in an effort to prioritize a sandbox deploy

@howard-e howard-e merged commit 937bf44 into trends May 21, 2024
2 checks passed
@howard-e howard-e deleted the trends-table branch May 21, 2024 20:23
@howard-e howard-e mentioned this pull request Jun 20, 2024
howard-e added a commit that referenced this pull request Jun 20, 2024
This includes work to support #791 and #792.

Includes the following changes:
* #1055
* #1001
* #1065
* #1052 
* #1087
* #1098 
* #1092
* #1131
* #1124

---------

Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
Co-authored-by: Paul Clue <67766160+Paul-Clue@users.noreply.github.com>
Co-authored-by: alflennik <alflennik@users.noreply.github.com>
howard-e added a commit that referenced this pull request Jun 24, 2024
Includes the following changes:
* #1123, addresses #791 and #792 with:
  * #1055
  * #1001
  * #1065
  * #1052 
  * #1087
  * #1098 
  * #1092
  * #1131
  * #1124
* #1128, addresses #1100
* #1102, addresses #957
* #1132
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants