feat: Support minimum and exact AT Version requirements in Test Run's version selection modal #1131
Conversation
…AndBrowserDetailsModal
…t AT version is set
There was a problem hiding this comment.
Code changes are clear and straightforward. I tested manually with VoiceOver by adding a test plan report with both minimum and exact requirements. With a minimum requirement, version options that do not meet the requirement are not shown in the dropdown. With an exact the warning is displayed and the version select is shown as a disabled text field with the required version. This reads/navigates well with VO.
Thanks for these changes!
| {exactAtVersion ? ( | ||
| <> | ||
| <Form.Label> | ||
| Assistive Technology Version | ||
| </Form.Label> | ||
| <Form.Control | ||
| disabled | ||
| type="text" | ||
| value={exactAtVersion.name} | ||
| /> | ||
| </> | ||
| ) : ( |
| ); | ||
| return ( | ||
| new Date(item.releasedAt) >= | ||
| earliestReleasedAt |
There was a problem hiding this comment.
At some point it might be good to break this out into a utility function so that we can unit test these comparisons to harden against any future changes to ATVersion. Not a requirement right now and I can easily add when doing the automation at version comparison work if preferred.
There was a problem hiding this comment.
I think I'll leave it up to a future PR because since there's a couple places where some date comparison is being done. Would rather some dedicated time be taken to pull those all together if creating a utility on that.
... and I can easily add when doing the automation at version comparison work if preferred
@stalgiag that's my preference right now, but great call out on this and definitely include me as a reviewer when doing so!
This includes work to support #791 and #792. Includes the following changes: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 --------- Co-authored-by: Howard Edwards <howarde.edwards@gmail.com> Co-authored-by: Paul Clue <67766160+Paul-Clue@users.noreply.github.com> Co-authored-by: alflennik <alflennik@users.noreply.github.com>
This is related to discussions shared in #791. This PR makes the following changes to the
<AtAndBrowserDetailsModal>component:TestPlanReport, it prevents AT Versions released before the minimum specified AT Version to be selected on the Test Run page.TestPlanReport, it Includes a disclaimer message that it's expected that the tester is using the specified AT Version and prevents any AT Version selection. The disclaimer message is: