FIM System tests: Scenario 0207 report changes #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra parameters variable
…nario-report-changes
rshad
changed the title
xr09
approved these changes
Feb 27, 2020
jm404
suggested changes
Feb 27, 2020
| @@ -9,7 +9,7 @@ | |||
| - name: "Verify alert json log | {{ event }}" | |||
| script: > | |||
| verify_alerts_json.py -i {{ item.path }} -e {{ event }} | |||
| -o {{ missing_alerts_json_path }} | |||
| -o {{ missing_alerts_json_path }} {{ verify_json_script_extra_params }} | |||
There was a problem hiding this comment.
Please let's standardize this as json_verification_extra_arguments, as commented in #549 (comment)
| @@ -21,7 +21,7 @@ | |||
| script: > | |||
| verify_alerts_elasticsearch.py -i {{ item.path }} -e {{ event }} | |||
| -a {{ hostvars[groups["elasticsearch"][0]]["private_ip"] }} | |||
| -o {{ missing_alerts_elasticsearch_path }} | |||
| -o {{ missing_alerts_elasticsearch_path }} {{ verify_ES_script_extra_params }} | |||
There was a problem hiding this comment.
Let's standardize this as elastic_verification_extra_arguments
| @@ -0,0 +1 @@ | |||
| agents_outputs | |||
There was a problem hiding this comment.
I just noticed the scenario folder, is too long and doesn't describe the trigger, the syntax na me is id_description_trigger, please consider changing it to 207_report_changes_frequency
xr09
approved these changes
Feb 27, 2020
15 tasks
…nario-report-changes
…com/wazuh/wazuh-qa into feature-523-scenario-report-changes
jm404
approved these changes
Mar 2, 2020
…nario-report-changes
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This PR resolves #523 .
Kr,
Rshad