FIM System tests: 0202 - Realtime monitoring #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wazuh-qa into feature-531-realtime-scenario
spothound
commented
Feb 27, 2020
spothound
commented
Feb 27, 2020
jm404
suggested changes
Feb 27, 2020
| verify_alerts_json.py -i {{ item.path }} -e {{ event }} | ||
| -o {{ missing_alerts_json_path }} | ||
| verify_alerts_json.py -i {{ item.path }} -e {{ event }} | ||
| -o {{ missing_alerts_json_path }} {{ alert_verification_extra_arguments }} |
There was a problem hiding this comment.
{{ elastic_verification_extra_arguments }} is also an alert verification, please consider changing it to {{ json_verification_extra_arguments }} as it's related to alerts.json` verification
There was a problem hiding this comment.
But what if those scripts accept different parameters in the future?
There was a problem hiding this comment.
The {{ elastic_verification_extra_arguments }} will accept multiple parameters and will be declared using set_fact. E.G:
set_fact:
elastic_verification_extra_arguments: "-s 60 -w True"
5 tasks
…ion/generation scripts
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #531
Ready for review. I'm getting a lot of error generating alerts with realtime when the scan frequency is high. I'm investigating it but meanwhile, you could review the changes.
Best regards.