Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Split GRPC code of related contexts into separate files #798

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 25, 2022

from #796

@6543 6543 added server refactor delete or replace old code labels Feb 25, 2022
@6543 6543 added this to the 1.0.0 milestone Feb 25, 2022
@6543 6543 requested a review from anbraten February 25, 2022 20:46
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #798 (ef1220a) into master (8ae124d) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head ef1220a differs from pull request most recent head bed64ac. Consider uploading reports for the commit bed64ac to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   55.99%   55.90%   -0.10%     
==========================================
  Files          76       76              
  Lines        5543     5543              
==========================================
- Hits         3104     3099       -5     
- Misses       2266     2271       +5     
  Partials      173      173              
Impacted Files Coverage Δ
server/logging/log.go 48.83% <0.00%> (-5.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc8122...bed64ac. Read the comment docs.

@anbraten anbraten changed the title split related func into own files Split GRPC code of related contexts into separate files Feb 26, 2022
@6543 6543 merged commit 4607cf5 into woodpecker-ci:master Feb 26, 2022
@6543 6543 deleted the server-grpc-split-file-into-topic-related-files branch February 26, 2022 13:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactor delete or replace old code server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants