Collected Nits

[6543]

collected nits over the last months ...

[6543]

code remove is split out to #797 ...

[codecov-commenter]

Codecov Report

Merging #796 (e3c1655) into master (ecc2539) will decrease coverage by 3.11%.
The diff coverage is 100.00%.

❗ Current head e3c1655 differs from pull request most recent head 22283bb. Consider uploading reports for the commit 22283bb to get more accurate results

@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   55.27%   52.16%   -3.12%     
==========================================
  Files          78       86       +8     
  Lines        5610     5956     +346     
==========================================
+ Hits         3101     3107       +6     
- Misses       2331     2676     +345     
+ Partials      178      173       -5     

Impacted Files	Coverage Δ
server/shared/procBuilder.go	86.24% <100.00%> (+0.05%)	⬆️
server/store/datastore/build.go	77.65% <100.00%> (+0.48%)	⬆️
server/remote/gitlab/gitlab.go	27.02% <0.00%> (-0.07%)	⬇️
server/remote/bitbucketserver/bitbucketserver.go	0.00% <0.00%> (ø)
server/remote/common/utils.go
server/remote/common/status.go
server/plugins/secrets/builtin.go	0.00% <0.00%> (ø)
server/router/middleware/session/repo.go	0.00% <0.00%> (ø)
server/plugins/registry/filesystem.go	0.00% <0.00%> (ø)
server/plugins/registry/db.go	0.00% <0.00%> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc2539...22283bb. Read the comment docs.

[qwerty287]

@6543 what is this actually about? Can we close it or just merge the TODOs you added? Or do you want to resolve them here?

[6543]

hmm well that's the only commit thing left at this "parking log"

so we could just open issues for the to do and close it

[qwerty287]

Opened issues: #1257 #1258