Skip to content

Implement remove command #335

Implement remove command

Implement remove command #335

Triggered via pull request February 19, 2025 16:50
@rk1274rk1274
synchronize #89
remove-command
Status Failure
Total duration 33s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 3 warnings
lint: server/server.go#L221
Function 'handleRemoveRequests' is too long (31 > 30) (funlen)
lint: baton/baton.go#L75
commentFormatting: put a space between `//` and comment text (gocritic)
lint: baton/baton.go#L372
Comment should end in a period (godot)
lint: baton/baton.go#L406
baton/baton.go:406: Line contains TODO/BUG/FIXME: "TODO only take remote" (godox)
lint: remove/remove.go#L47
remove/remove.go:47: Line contains TODO/BUG/FIXME: "TODO" (godox)
lint: remove/remove.go#L59
remove/remove.go:59: Line contains TODO/BUG/FIXME: "TODO" (godox)
lint: remove/remove.go#L115
the line is 124 characters long, which exceeds the maximum of 120 characters. (lll)
lint: put/request.go#L353
the line is 124 characters long, which exceeds the maximum of 120 characters. (lll)
lint: baton/baton.go#L386
Consider pre-allocating `openClients` (prealloc)
lint: internal/mock.go#L267
(*LocalHandler).QueryMeta - result 1 (error) is always nil (unparam)
lint: internal/mock.go#L139
unused-parameter: parameter 'meta' seems to be unused, consider removing or renaming it as _ (revive)
lint: remove/remove.go#L68
exported: func name will be used as remove.RemovePathFromSetInIRODS by other packages, and that stutters; consider calling this PathFromSetInIRODS (revive)
lint: remove/remove.go#L128
exported: func name will be used as remove.RemoveDirFromIRODS by other packages, and that stutters; consider calling this DirFromIRODS (revive)