Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(hooks): Add new config:resolved hook #1177

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Nov 15, 2024

This hook is called right after ready and whenever config is reloaded during development. It should be used to apply changes to the config going forward.

If you use ready to update config, during development, the changes you make will be removed after a file is saved. See #1128 for an example of what this looks like.

This closes #1128.

@aklinker1 aklinker1 self-assigned this Nov 15, 2024
Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit a02bf59
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/67375ed8cdae700008e3d0f7
😎 Deploy Preview https://deploy-preview-1177--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1177

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1177

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1177

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1177

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1177

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1177

@wxt-dev/storage

pnpm add https://pkg.pr.new/@wxt-dev/storage@1177

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1177

wxt

pnpm add https://pkg.pr.new/wxt@1177

commit: 0d8a9be

@aklinker1 aklinker1 changed the title feat(hooks): Create new config:resolved hook feat: Use new config:resolved hook to update config Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (52e5387) to head (a02bf59).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/modules.ts 28.57% 5 Missing ⚠️
packages/wxt/src/core/wxt.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1177      +/-   ##
==========================================
- Coverage   80.65%   80.53%   -0.13%     
==========================================
  Files         127      127              
  Lines        6033     6036       +3     
  Branches     1016     1014       -2     
==========================================
- Hits         4866     4861       -5     
- Misses       1152     1160       +8     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review November 15, 2024 14:39
@aklinker1 aklinker1 changed the title feat: Use new config:resolved hook to update config feat(modules): Use new config:resolved hook to update config Nov 15, 2024
@aklinker1 aklinker1 changed the title feat(modules): Use new config:resolved hook to update config feat(hooks): Add new config:resolved hook Nov 15, 2024
@aklinker1 aklinker1 merged commit 4d4453b into main Nov 15, 2024
18 checks passed
@aklinker1 aklinker1 deleted the config-resolved-hook branch November 15, 2024 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant