Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Use config:resolved hook to update config instead of ready #1178

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Nov 15, 2024

Follow up to #1177 fixing all the other modules usage of "ready".

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 593b256
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/673762b208a55400083d2008
😎 Deploy Preview https://deploy-preview-1178--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aklinker1 aklinker1 marked this pull request as ready for review November 15, 2024 15:03
Copy link

pkg-pr-new bot commented Nov 15, 2024

Open in Stackblitz

@wxt-dev/auto-icons

pnpm add https://pkg.pr.new/@wxt-dev/auto-icons@1178

@wxt-dev/i18n

pnpm add https://pkg.pr.new/@wxt-dev/i18n@1178

@wxt-dev/module-react

pnpm add https://pkg.pr.new/@wxt-dev/module-react@1178

@wxt-dev/module-solid

pnpm add https://pkg.pr.new/@wxt-dev/module-solid@1178

@wxt-dev/module-svelte

pnpm add https://pkg.pr.new/@wxt-dev/module-svelte@1178

@wxt-dev/module-vue

pnpm add https://pkg.pr.new/@wxt-dev/module-vue@1178

@wxt-dev/storage

pnpm add https://pkg.pr.new/@wxt-dev/storage@1178

@wxt-dev/unocss

pnpm add https://pkg.pr.new/@wxt-dev/unocss@1178

wxt

pnpm add https://pkg.pr.new/wxt@1178

commit: 593b256

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (4d4453b) to head (593b256).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
- Coverage   80.50%   80.41%   -0.09%     
==========================================
  Files         127      127              
  Lines        6036     6036              
  Branches     1016     1015       -1     
==========================================
- Hits         4859     4854       -5     
- Misses       1162     1167       +5     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 merged commit eb1ace6 into main Nov 15, 2024
18 checks passed
@aklinker1 aklinker1 deleted the config-resolved-hook-updates branch November 15, 2024 15:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant