-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update xunit version to 2.4.2-pre.12 #304
Conversation
@clairernovotny the PR is now green 😄 (please squash the commits) |
Can you please test it from the preview feed |
@clairernovotny just tested the package and it works as expected. Would be great if you could publish it to NuGet.org. The only weird thing is that it is called "2.4.4-preview.17". |
@clairernovotny I tried your package out on a project that worked well but @eiriktsarpalis just me know that it doesn't work for any test project that targetes net462. I think this is related to your change. Is it expected that support for previous .NETFramework versions is dropped? |
That's correct. I'm pretty sure there was a reason for that, perhaps targeting packs missing or some such. I honestly don't remember at this point. |
IMO that's a pretty big break for a minor version bump (I think that shipped in 2.4.3?). Just wondering if I'm the only one who was surprised by that. For us in dotnet/runtime that means that we need to update all our test projects which target .NETFramework. |
My recollection of why is completely absent right now, sorry. I'm happy to make it 4.6.2, the lowest supported .NET runtime, but it'll need to be a PR as I won't have time to make the changes myself for awhile. I think all the touchpoints are in that commit you linked before. |
Depend on the latest released xunit packages as their assembly versions got updated to 2.4.2 instead of 2.4.1.
@clairernovotny you already updated the package version in the version.json file this February. Do we need another update or are your changes sufficient? And is the produced package automatically published to nuget.org when merged into main?
Last question, do we want to update the packages with a prerelease label same as the other xunit package or is stable fine?