Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Downgrade xunit.runner.vs to net462 #308

Merged
merged 2 commits into from
May 5, 2022

Conversation

ViktorHofer
Copy link
Contributor

See discussion in #304 (comment) for context. .NETFramework 4.6.2 and above is still in support and support shouldn't be dropped for it from the package.

@ViktorHofer
Copy link
Contributor Author

ViktorHofer commented May 5, 2022

@clairernovotny here's the PR for the downgrade from net472 to net462. I also updated to the latest xunit preview package.

@clairernovotny clairernovotny merged commit c8e7163 into xunit:main May 5, 2022
@clairernovotny
Copy link
Member

Has this been tested--do you need to test the built version from the CI feed or should I go publish a new stable?

@ViktorHofer ViktorHofer deleted the XUnitDowngradeToNet462 branch May 5, 2022 16:05
@ViktorHofer
Copy link
Contributor Author

Please publish the new version. I already verified offline that the produced package contains the expected assets.

kevinoid added a commit to kevinoid/NetCoreProject that referenced this pull request Nov 14, 2022
Since xunit.runner.visualstudio 2.4.5 only supports .NET 4.6.2 and
later: xunit/visualstudio.xunit#308

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/NetCoreProject that referenced this pull request Nov 14, 2022
Since xunit.runner.visualstudio 2.4.5 only supports .NET 4.6.2 and
later: xunit/visualstudio.xunit#308

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/NLCaseConvert that referenced this pull request Nov 15, 2022
Since xunit.runner.visualstudio 2.4.5 only supports .NET 4.6.2 and
later: xunit/visualstudio.xunit#308

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants