Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for Ember v5 #124

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SergeAstapov
Copy link
Contributor

Without this change, you have an issue installing Ember.js v5:

unmet peer ember-source@^4.0.0: found 5.3.0

@lukemelia
Copy link
Contributor

Hmm, any idea what's going on with CI @SergeAstapov ?

@lukemelia
Copy link
Contributor

Also, this is compatible with Ember 3.28, so let's make the peer dep say as much

@SergeAstapov
Copy link
Contributor Author

Also, this is compatible with Ember 3.28, so let's make the peer dep say as much

not sure, as both readme and CI have 4.4+, but I can update of course to be 3.28+, which I think would be separate PR.

As for CI errors

Build Error (broccoli-persistent-filter:Babel > [Babel: @ember/test-helpers]) in @ember/test-helpers/-internal/build-registry.js

[BABEL]: Cannot find module '@babel/helper-get-function-arity'

this seen like lock file needs and update + maybe some reps. I should be able to take a look into that in separate PR

@paddor
Copy link

paddor commented Feb 16, 2024

Any updates here? I'd love to upgrade to Ember 5.x without using npm i --legacy-peer-deps.

@lukemelia
Copy link
Contributor

I haven't had time to look at this myself. I'm traveling but happy to review a PR.

@mansona mansona mentioned this pull request Mar 5, 2024
@lukemelia
Copy link
Contributor

Handled in #129

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants