Update to Ember v5.4 with ember-cli-update #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
ember-5
branch
4 times, most recently
from
6ff3825 to
16272f9
Compare
|
Released as v3.1.0. Thanks @mansona! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should also fix support for Ember v5 (by fixing the peer dependency) and re-instate the testing for Ember v3.28 👍
This includes the work in #128 so we should merge that firstEdit: this is ready to merge (if you would like)Note: I had to downgrade the version of ember-qunit from the upgraded blueprint because it doesn't seem to be playing nice with your custom styles. I didn't really understand what was going on so I didn't try to fix it on the latest version and figured that's something you might want to take a look at 😂