Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: added a new query button #238 #259

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

vitshev
Copy link
Collaborator

@vitshev vitshev commented Dec 19, 2023

@vitshev vitshev marked this pull request as ready for review December 19, 2023 12:54
@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch from 2a8fc68 to a584676 Compare December 19, 2023 12:55
@ma-efremoff
Copy link
Collaborator

When QT is opened as side-panel from page of some table a click to the button change the page from Navigation to Queries.

@vitshev
Copy link
Collaborator Author

vitshev commented Dec 20, 2023

image

@vitshev vitshev marked this pull request as draft December 20, 2023 10:42
@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch 2 times, most recently from da9e7d6 to 98abd3e Compare December 20, 2023 16:57
@vitshev vitshev marked this pull request as ready for review December 21, 2023 08:58
@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch from 98abd3e to 4335e93 Compare December 21, 2023 09:57
@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch 3 times, most recently from 126804d to 8780b89 Compare December 21, 2023 16:28
@ma-efremoff
Copy link
Collaborator

It is better to display confirmation dialog if query is changed.
image

@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch 8 times, most recently from 1f4fe1b to d701f11 Compare January 12, 2024 13:32
@vitshev
Copy link
Collaborator Author

vitshev commented Jan 15, 2024

@ma-efremoff

@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch 3 times, most recently from ebb2ab5 to cf36ae6 Compare January 17, 2024 13:14
@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch 4 times, most recently from 1ed529e to 77fb421 Compare January 17, 2024 15:02
@vitshev vitshev force-pushed the vitshev/new-query-button-issue-238 branch from 77fb421 to e5f0165 Compare January 17, 2024 15:04
@vitshev vitshev merged commit b66fa31 into main Jan 17, 2024
7 checks passed
@vitshev vitshev deleted the vitshev/new-query-button-issue-238 branch January 17, 2024 15:18
@ma-efremoff ma-efremoff restored the vitshev/new-query-button-issue-238 branch January 20, 2025 08:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants