Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add check for update strategy #570

Closed
joshiste opened this issue Dec 12, 2023 · 1 comment · Fixed by #576
Closed

Add check for update strategy #570

joshiste opened this issue Dec 12, 2023 · 1 comment · Fixed by #576

Comments

@joshiste
Copy link

There is no check on the update strategy.

To avoid interruptions during updates of deployments/statefulsets it's advisable to use a rolling update strategy.
I think it is reasonable to add this check if the pods are targeted by a service to check for the update strategy.

KubeLinter has this check. Let me know what you think. If you find this acceptable, I'd happily contribute a PR.

@zegl
Copy link
Owner

zegl commented Dec 12, 2023

Yes, this makes sense for Deployments. Add a warning if the strategy is "Recreate" and the Deployment is targeted by a Service.

BigGold1310 added a commit to BigGold1310/kube-score that referenced this issue Jan 4, 2024
…be Rolling if targeted by Service

Fixes zegl#570

Signed-off-by: BigGold1310 <cyrill.naef@gmail.com>
BigGold1310 added a commit to BigGold1310/kube-score that referenced this issue Jan 4, 2024
…be Rolling if targeted by Service

Fixes zegl#570

Signed-off-by: BigGold1310 <cyrill.naef@gmail.com>
@zegl zegl closed this as completed in #576 Jan 5, 2024
@zegl zegl closed this as completed in 8f4d9fa Jan 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants