Add deployment checks #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be Rolling if targeted by Service Fixes zegl#570 Signed-off-by: BigGold1310 <cyrill.naef@gmail.com>
zegl
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Thanks for working on this!
In general this looks fantastic, just two changes:
- We should not require the deployment strategy to be explicitly set.
RollingUpdateis the default value, and that should be OK for us. - Some changes to the copy to make the warnings more actionable.
score/deployment_test.go
Outdated
|
|
||
| func TestServiceNotTargetsDeploymentStrategyNotRelevant(t *testing.T) { | ||
| t.Parallel() | ||
| // Expecting score 0 as it didn't cot rated |
There was a problem hiding this comment.
Removed comment as it should be clear without it.
score/deployment_test.go
Outdated
Comment on lines
31
to
33
| func TestServiceTargetsDeploymentStrategyNotSet(t *testing.T) { | ||
| t.Parallel() | ||
| testExpectedScore(t, "service-target-deployment-strategy-not-set.yaml", "Deployment Strategy", scorecard.GradeWarning) | ||
| } |
There was a problem hiding this comment.
RollingUpdate is the default strategy, I don't think that we should require users to explicitly set the strategy to get rid of the warning.
If no strategy is set, the grade should be GradeAllOK.
There was a problem hiding this comment.
Good point, updated to GradeAllOk
…if not HPA managed and targeted by Service Fixes zegl#569 Signed-off-by: BigGold1310 <cyrill.naef@gmail.com>
zegl
force-pushed
the
add-deployment-checks
branch
from
c3959ae to
32ce7ab
Compare
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569
Fixes #570