Merge pull request #280 from njdancer/fix/snap-back-on-mobile

fix: snap back on mobile devices
zillow · Jun 3, 2023 · 874122b · 874122b
2 parents 5e81291 + 6ca5853
commit 874122b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/components/ReactSlider/ReactSlider.jsx b/src/components/ReactSlider/ReactSlider.jsx
@@ -433,7 +433,8 @@ class ReactSlider extends React.Component {
         this.onEnd(this.getMouseEventMap());
     };
 
-    onTouchEnd = () => {
+    onTouchEnd = e => {
+        e.preventDefault();
         this.onEnd(this.getTouchEventMap());
     };
 
@@ -849,7 +850,10 @@ class ReactSlider extends React.Component {
     }
 
     move(newValue) {
-        const { index, value } = this.state;
+        // Clone this.state.value since we'll modify it temporarily
+        // eslint-disable-next-line zillow/react/no-access-state-in-setstate
+        const value = this.state.value.slice();
+        const { index } = this.state;
         const { length } = value;
 
         // Short circuit if the value is not changing