-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Teensyduino Compatibility Updates #28
Open
dmadison
wants to merge
34
commits into
zlittell:master
Choose a base branch
from
dmadison:teensy-updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only keep modified files
These changes will get re-added in a bit, I just need to move the files out of the way first.
Taken from the PaulStoffregen/cores repo at 6ed0c5f01fbd20449c12d9a54cd4c529e7532bdf (1.21)
This isn't included in the 'cores' repo, so I had to take it from the installer. The 1.28+ version included in the original modifications does not match the cores file commits, so I'm using the original 1.21 file and working up.
Did not included the serial modifications because they were from an older commit (f8938ec) that is included and overwritten in cores
These are now correcly merged with the cores files. Yay!
Mimics the USB_DISABLED functionality in creating a dummy Serial class.
Not sure why this is straight-up commented out, as the compiler throws a fit in any other modes except XInput that use the daisy-chain definition here.
Stores the copyright symbol as its unicode hex representation rather than a character literal, and explicitly brackets the security descriptor array initializer.
These are functionally identical, so the different naming is more confusing than anything.
Easier to track these as XInput associated changes while updating.
No cores file updates.
Adds MTP descriptors
No changes between 1.34 and 1.35
Note that the Teensy LC has a compilation bug in the 1.38 release. This is fixed in 1.39.
Teensy now uses the BCD_DEVICE macro where a custom macro for XInput was previously used, so that macro name for XInput has been updated in usb_desc.h
This is a merge with DJQuardaboff's changes that got pulled into the master branch.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went back and found the commit where you made the initial modifications, then updated the library for each release in turn until I got to the most recent version.
Changes from original:
USB_DISABLED
flag, which is easier and requires fewer modifications. ASerial
class instance still exists for compatibility with existing code.I tested each version update using a generic Serial example (USB Serial mode) and the library
Simple_Example
(USB XInput mode), as well as a few random examples here and there.(Note that the dates are the release dates of the Teensyduino versions, not the date for that version's
cores
commit.)This update also adds compatibility support for 1.43.
I spent awhile trying to figure out how to do this "cleanly" so it would import from the
cores
repo and you could pull in files for new releases, but I never could figure out how to do it so that you didn't have to track all of the other unrelated files. For each version update I downloaded the old installers and created a new temporary installation, then copied over the vanilla files and resolved the conflicts in git. Tedious, but it got the job done and the result is clean.This pull request will hopefully bring the repo fully up to date, fixing the few discrepancies in the last update pull request (#26). It will also introduce versioned commits for users with legacy Teensyduino software.